BUG: Tweak readonly layer handling for migrations

[invisig0th]

No description provided.

[Cisphyx]

I think Layer.saveNodeEdits and Layer.storNodeEditsNoLift need readonly checks as well as there are some layer syncing/admin APIs which use those.

[invisig0th]

I think Layer.saveNodeEdits and Layer.storNodeEditsNoLift need readonly checks as well as there are some layer syncing/admin APIs which use those.

Yep, they were already using it i think?

[Cisphyx]

I think Layer.saveNodeEdits and Layer.storNodeEditsNoLift need readonly checks as well as there are some layer syncing/admin APIs which use those.

Yep, they were already using it i think?

Ah yep nevermind, they already are, apparently I was looking at the wrong thing.

[codecov]

Codecov Report

Patch coverage: 96.22% and project coverage change: -0.11% ⚠️

Comparison is base (ac1eec0) 97.28% compared to head (82e0a97) 97.18%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3313      +/-   ##
==========================================
- Coverage   97.28%   97.18%   -0.11%     
==========================================
  Files         228      228              
  Lines       45863    45878      +15     
==========================================
- Hits        44620    44587      -33     
- Misses       1243     1291      +48     

Flag	Coverage Δ
linux	97.18% <96.22%> (-0.01%)	⬇️
linux_replay	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
synapse/lib/modelrev.py	98.23% <92.59%> (-0.01%)	⬇️
synapse/cortex.py	96.99% <100.00%> (-0.49%)	⬇️
synapse/lib/layer.py	96.72% <100.00%> (-0.11%)	⬇️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.