Mark the cryotank iden keyword argument as deprecated. #3326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikemoritz
reviewed
Sep 5, 2023
| @@ -151,14 +151,15 @@ async def slice(self, offs, size=None, iden=None, wait=False, timeout=None): | |||
| Args: | |||
| offs (int): The index of the desired datum (starts at 0) | |||
| size (int): The max number of items to yield. | |||
| iden (str): The iden for offset tracking. | |||
| iden (str): The iden for offset tracking. This argument is deprecated. Callers should track offsets. | |||
There was a problem hiding this comment.
puts() and rows() use this too; did you want to also mark those?
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3326 +/- ##
==========================================
- Coverage 97.29% 97.18% -0.12%
==========================================
Files 228 228
Lines 46001 46013 +12
==========================================
- Hits 44757 44718 -39
- Misses 1244 1295 +51
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
mikemoritz
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
iden=argument on the CryoCell and CryoTank is marked as deprecated. It will be removed in v2.150.0.Callers should track offsets locally.