-
Notifications
You must be signed in to change notification settings - Fork 78
Add CryoTank permissions (SYN-3773) #3328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mikemoritz
commented
Sep 5, 2023
- Also removed deprecated offset tracking (cannot be released until >=2.150.0)
- Includes migration to remove old tank-cell data and match guids between the cryo names and the tanks
# Conflicts: # synapse/cryotank.py
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3328 +/- ##
==========================================
- Coverage 97.27% 97.17% -0.10%
==========================================
Files 228 228
Lines 46503 46515 +12
==========================================
- Hits 45234 45202 -32
- Misses 1269 1313 +44
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we override _getPermDefs() on the CryoCell to list the cryotank permissions?
cryo.tank.read
cryo.tank.put
cryo.tank.add
Added |