Skip to content

Add CryoTank permissions (SYN-3773) #3328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Sep 21, 2023
Merged

Add CryoTank permissions (SYN-3773) #3328

merged 14 commits into from
Sep 21, 2023

Conversation

mikemoritz
Copy link
Contributor

  • Also removed deprecated offset tracking (cannot be released until >=2.150.0)
  • Includes migration to remove old tank-cell data and match guids between the cryo names and the tanks

@mikemoritz mikemoritz changed the title WIP: Add CryoTank permissions (SYN-3773) Add CryoTank permissions (SYN-3773) Sep 6, 2023
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.10% ⚠️

Comparison is base (23402e7) 97.27% compared to head (8565f13) 97.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3328      +/-   ##
==========================================
- Coverage   97.27%   97.17%   -0.10%     
==========================================
  Files         228      228              
  Lines       46503    46515      +12     
==========================================
- Hits        45234    45202      -32     
- Misses       1269     1313      +44     
Flag Coverage Δ
linux 97.17% <100.00%> (+<0.01%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
synapse/cryotank.py 98.51% <100.00%> (+6.93%) ⬆️

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vEpiphyte vEpiphyte added this to the v2.150.0 milestone Sep 6, 2023
@vEpiphyte vEpiphyte added enhancement reqChangelog requires changelog labels Sep 6, 2023
vEpiphyte
vEpiphyte previously approved these changes Sep 15, 2023
Copy link
Contributor

@MichaelSquires MichaelSquires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we override _getPermDefs() on the CryoCell to list the cryotank permissions?

cryo.tank.read
cryo.tank.put
cryo.tank.add

@mikemoritz
Copy link
Contributor Author

Should we override _getPermDefs() on the CryoCell to list the cryotank permissions?

cryo.tank.read cryo.tank.put cryo.tank.add

Added

vEpiphyte
vEpiphyte previously approved these changes Sep 21, 2023
@mikemoritz mikemoritz merged commit e4e9b98 into master Sep 21, 2023
@mikemoritz mikemoritz deleted the redox/cryotank_perms branch September 21, 2023 20:11
@vEpiphyte vEpiphyte removed the reqChangelog requires changelog label Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants