Skip to content

SYN-6078: view worldreadable flag when making views in storm #3333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 8, 2023

Conversation

MichaelSquires
Copy link
Contributor

  • Added worldreadable arg/flag to cortex, $lib.view.add, and view.add.
  • Added tests

Resolves SYN-6078

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.10% ⚠️

Comparison is base (b49859e) 97.28% compared to head (1c238af) 97.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3333      +/-   ##
==========================================
- Coverage   97.28%   97.18%   -0.10%     
==========================================
  Files         228      228              
  Lines       46013    46014       +1     
==========================================
- Hits        44766    44721      -45     
- Misses       1247     1293      +46     
Flag Coverage Δ
linux 97.18% <100.00%> (+<0.01%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
synapse/lib/storm.py 95.71% <ø> (ø)
synapse/lib/stormtypes.py 98.74% <100.00%> (+<0.01%) ⬆️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelSquires MichaelSquires marked this pull request as ready for review September 7, 2023 14:12
@vEpiphyte vEpiphyte added this to the v2.14x.x milestone Sep 7, 2023
@vEpiphyte vEpiphyte added enhancement reqChangelog requires changelog labels Sep 7, 2023
@MichaelSquires MichaelSquires merged commit 715de85 into master Sep 8, 2023
@vEpiphyte vEpiphyte deleted the blackout/SYN-6078/view-worldreadable-flag branch September 19, 2023 11:59
@vEpiphyte vEpiphyte removed the reqChangelog requires changelog label Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants