Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYN-5982: best-effort windows/linux file path scrape #3343

Merged
merged 3 commits into from
Sep 14, 2023

Conversation

MichaelSquires
Copy link
Contributor

feat: Add windows/linux file path scrape
test: Updated scrape test

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.10% ⚠️

Comparison is base (dcccde6) 97.29% compared to head (db9be42) 97.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3343      +/-   ##
==========================================
- Coverage   97.29%   97.19%   -0.10%     
==========================================
  Files         228      228              
  Lines       46036    46066      +30     
==========================================
- Hits        44789    44773      -16     
- Misses       1247     1293      +46     
Flag Coverage Δ
linux 97.19% <100.00%> (+0.02%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
synapse/lib/scrape.py 99.50% <100.00%> (+0.08%) ⬆️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelSquires MichaelSquires marked this pull request as ready for review September 13, 2023 18:40
@vEpiphyte vEpiphyte added this to the v2.14x.x milestone Sep 14, 2023
@vEpiphyte vEpiphyte added enhancement reqChangelog requires changelog labels Sep 14, 2023
@vEpiphyte vEpiphyte merged commit 06b2955 into master Sep 14, 2023
@vEpiphyte vEpiphyte deleted the blackout/SYN-5982/scrape-winlin-filepaths branch September 14, 2023 17:14
@vEpiphyte vEpiphyte removed the reqChangelog requires changelog label Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants