SYN-5969: scrape and inet:url norm to recognize win UNC network paths and convert to smb:// URLs #3347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3347 +/- ##
==========================================
- Coverage 97.26% 97.15% -0.12%
==========================================
Files 228 228
Lines 46397 46462 +65
==========================================
+ Hits 45128 45138 +10
- Misses 1269 1324 +55
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
MichaelSquires
commented
Sep 15, 2023
MichaelSquires
force-pushed
the
blackout/SYN-5969/unc-paths
branch
from
f7919ab to
569c82b
Compare
MichaelSquires
changed the title
invisig0th
requested changes
Sep 18, 2023
Cisphyx
reviewed
Sep 18, 2023
Cisphyx
approved these changes
Sep 19, 2023
invisig0th
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: scrape UNC paths
feat: inet:url norming UNC paths to smb:// URLs
test: updated tests