Skip to content

Update getLogExtra behavior to prefer a user key (SYN-6047) #3356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 6, 2023

Conversation

vEpiphyte
Copy link
Contributor

No description provided.

Update Storm related endpoints to set the user key to properly capture data from queries proxied via the user key
@vEpiphyte vEpiphyte added enhancement reqChangelog requires changelog labels Sep 27, 2023
@vEpiphyte vEpiphyte changed the title Update getLogExtra behavior to prefer as user key (SYN-6047) Update getLogExtra behavior to prefer a user key (SYN-6047) Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (a8c1406) 97.31% compared to head (abf4c61) 97.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3356      +/-   ##
==========================================
- Coverage   97.31%   97.21%   -0.10%     
==========================================
  Files         229      229              
  Lines       46836    46845       +9     
==========================================
- Hits        45577    45540      -37     
- Misses       1259     1305      +46     
Flag Coverage Δ
linux 97.21% <100.00%> (+<0.01%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
synapse/cortex.py 97.01% <100.00%> (-0.49%) ⬇️
synapse/lib/cell.py 97.83% <100.00%> (+<0.01%) ⬆️
synapse/lib/snap.py 95.97% <ø> (-0.01%) ⬇️
synapse/lib/storm.py 95.71% <100.00%> (+<0.01%) ⬆️
synapse/lib/view.py 97.17% <100.00%> (-0.30%) ⬇️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vEpiphyte vEpiphyte added this to the v2.15x.x milestone Oct 6, 2023
@vEpiphyte vEpiphyte merged commit 21a33ac into master Oct 6, 2023
@vEpiphyte vEpiphyte deleted the feat_cell_logextra_user branch October 6, 2023 18:27
@vEpiphyte vEpiphyte removed the reqChangelog requires changelog label Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants