Update nexus readonly error to include reason text (SYN-6148) #3359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3359 +/- ##
==========================================
- Coverage 97.30% 97.20% -0.11%
==========================================
Files 228 228
Lines 46723 46731 +8
==========================================
- Hits 45463 45424 -39
- Misses 1260 1307 +47
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
invisig0th
requested changes
Oct 3, 2023
synapse/lib/nexus.py
Outdated
| @@ -271,7 +276,7 @@ async def issue(self, nexsiden, event, args, kwargs, meta=None): | |||
| assert self.started, 'Attempt to issue before nexsroot is started' | |||
|
|
|||
| if self.readonly: | |||
| raise s_exc.IsReadOnly(mesg='Unable to issue Nexus events when readonly is set') | |||
| raise s_exc.IsReadOnly(mesg=self.readonlyreason) | |||
There was a problem hiding this comment.
Do we need a default if reason isn't specified?
There was a problem hiding this comment.
Added a default reason.
invisig0th
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.