Skip to content

SYN-6186: crypto:smart:effect and it:host:activity interfaces need doc strings #3381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 12, 2023

Conversation

MichaelSquires
Copy link
Contributor

bugfix: Add doc strings to crypto:smart:effect, it:host:activity, and taxonomy interfaces.
test: Add test to check all types, props, edges, and interfaces have doc strings.

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e0a44e1) 97.29% compared to head (6a92220) 97.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3381      +/-   ##
==========================================
- Coverage   97.29%   97.21%   -0.08%     
==========================================
  Files         230      230              
  Lines       47046    47046              
==========================================
- Hits        45775    45738      -37     
- Misses       1271     1308      +37     
Flag Coverage Δ
linux 97.21% <ø> (+6.31%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
synapse/datamodel.py 95.81% <ø> (ø)
synapse/models/crypto.py 100.00% <ø> (ø)
synapse/models/infotech.py 98.70% <ø> (ø)

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelSquires MichaelSquires requested a review from rakuy0 October 12, 2023 17:57
@invisig0th invisig0th merged commit a719976 into master Oct 12, 2023
@invisig0th invisig0th deleted the blackout/SYN-6186/interface-docs branch October 12, 2023 23:47
@vEpiphyte vEpiphyte added this to the v2.15x.x milestone Oct 13, 2023
@vEpiphyte vEpiphyte added enhancement reqChangelog requires changelog and removed reqChangelog requires changelog labels Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants