Skip to content

Add edge trigger conditions, resolves SYN-6974 #3389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
Nov 1, 2023
Merged

Conversation

rakuy0
Copy link
Contributor

@rakuy0 rakuy0 commented Oct 17, 2023

No description provided.

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (2c5fbd7) 97.36% compared to head (a80d3c2) 97.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3389      +/-   ##
==========================================
- Coverage   97.36%   97.27%   -0.09%     
==========================================
  Files         233      233              
  Lines       47727    47892     +165     
==========================================
+ Hits        46469    46587     +118     
- Misses       1258     1305      +47     
Flag Coverage Δ
linux 97.27% <99.40%> (+<0.01%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
synapse/lib/cache.py 100.00% <100.00%> (ø)
synapse/lib/snap.py 96.01% <100.00%> (+0.03%) ⬆️
synapse/lib/storm.py 95.71% <ø> (ø)
synapse/lib/stormtypes.py 98.83% <100.00%> (+<0.01%) ⬆️
synapse/lib/view.py 97.22% <100.00%> (-0.27%) ⬇️
synapse/models/syn.py 98.41% <ø> (ø)
synapse/lib/trigger.py 96.41% <99.23%> (+0.99%) ⬆️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

invisig0th
invisig0th previously approved these changes Oct 23, 2023
@vEpiphyte vEpiphyte added this to the v2.15x.x milestone Oct 26, 2023
@vEpiphyte vEpiphyte added enhancement reqChangelog requires changelog labels Oct 27, 2023
@vEpiphyte vEpiphyte modified the milestones: v2.15x.x, v2.153.0 Oct 27, 2023
@vEpiphyte vEpiphyte modified the milestones: v2.153.0, v2.15x.x Oct 27, 2023
@rakuy0 rakuy0 merged commit e50d59a into master Nov 1, 2023
@rakuy0 rakuy0 deleted the trigger_edge_5974 branch November 1, 2023 19:56
@vEpiphyte vEpiphyte removed the reqChangelog requires changelog label Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants