Add $lib.iters.zip (SYN-4510) #3392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3392 +/- ##
==========================================
- Coverage 97.32% 97.22% -0.10%
==========================================
Files 231 231
Lines 46974 47027 +53
==========================================
+ Hits 45717 45723 +6
- Misses 1257 1304 +47
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
invisig0th
requested changes
Oct 20, 2023
mikemoritz
reviewed
Oct 23, 2023
|
|
||
| class StormLibItersTest(s_test.SynTest): | ||
|
|
||
| async def test_stormlib_iters_zip(self): |
There was a problem hiding this comment.
Might be good to add a test for one of the genrs raising an exception. The ExceptionGroup repr is not great, so I'm wondering if we could do something to make that a bit more clear.
invisig0th
approved these changes
Oct 23, 2023
vEpiphyte
added
reqChangelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.