Restart layer genrs in syncNodeEdits (SYN-6342) #3394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3394 +/- ##
==========================================
- Coverage 97.32% 97.23% -0.10%
==========================================
Files 231 231
Lines 47027 47040 +13
==========================================
- Hits 45769 45737 -32
- Misses 1258 1303 +45
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
mikemoritz
changed the title
invisig0th
requested changes
Oct 23, 2023
synapse/cortex.py
Outdated
| @@ -3849,11 +3849,11 @@ async def _syncNodeEdits(self, offsdict, genrfunc, wait=True): | |||
|
|
|||
| async with await s_base.Base.anit() as base: | |||
|
|
|||
| def addlayr(layr, newlayer=False): | |||
| def addlayr(layr, startoffs=topoffs, newlayer=False): | |||
There was a problem hiding this comment.
should the new option be last here?
Cisphyx
approved these changes
Oct 23, 2023
invisig0th
approved these changes
Oct 23, 2023
vEpiphyte
added
reqChangelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.