Skip to content

Pass per-node vars into subquery assignments (SYN-6428) #3405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 2, 2023

Conversation

invisig0th
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9d68ad9) 97.16% compared to head (9a3a0e7) 97.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3405      +/-   ##
==========================================
+ Coverage   97.16%   97.27%   +0.11%     
==========================================
  Files         233      233              
  Lines       47892    47895       +3     
==========================================
+ Hits        46533    46590      +57     
+ Misses       1359     1305      -54     
Flag Coverage Δ
linux 97.27% <100.00%> (+5.57%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
synapse/lib/ast.py 98.99% <100.00%> (+<0.01%) ⬆️

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@invisig0th invisig0th merged commit 935a40a into master Nov 2, 2023
@invisig0th invisig0th deleted the visi-subquery-scope branch November 2, 2023 19:56
@vEpiphyte vEpiphyte added this to the v2.154.0 milestone Nov 14, 2023
@vEpiphyte vEpiphyte added bug reqChangelog requires changelog labels Nov 14, 2023
@vEpiphyte vEpiphyte changed the title Pass per-node vars into subquery assignments Pass per-node vars into subquery assignments (SYN-6327) Nov 14, 2023
@vEpiphyte vEpiphyte changed the title Pass per-node vars into subquery assignments (SYN-6327) Pass per-node vars into subquery assignments (SYN-6428) Nov 14, 2023
@vEpiphyte vEpiphyte removed the reqChangelog requires changelog label Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants