Fix: Remove a check to deal with tags deleted in parent view, resolves SYN-6391 #3408
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3408 +/- ##
==========================================
- Coverage 97.39% 97.29% -0.10%
==========================================
Files 233 233
Lines 48176 48174 -2
==========================================
- Hits 46923 46873 -50
- Misses 1253 1301 +48
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…xproject/synapse into rakuyo/remove_missing_basetag_6391
…xproject/synapse into rakuyo/remove_missing_basetag_6391
vEpiphyte
added
bug
enhancement
reqChangelog
| @@ -529,7 +525,8 @@ async def _getTagDelEdits(self, tag, init=False): | |||
| edits.append((s_layer.EDIT_TAG_DEL, (subtag, None), ())) | |||
|
|
|||
| edits.extend(self._getTagPropDel(name)) | |||
There was a problem hiding this comment.
Does the tagpropdel on name also need to become conditional?
There was a problem hiding this comment.
No, because you can add a tag prop in the forked view to the root tag #foo and then remove #foo in the base view, we'd still have the node's self.getTagProps return the tagprop for the missing root tag when we're looking at it in the forked view.
So I think we'd still want to mop those tagprops up when removing a tag in the fork viefw, even if that root tag was missing.
No description provided.