Skip to content

Allow setting layers on a root view with forks #3413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 14, 2023
Merged

Conversation

invisig0th
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (97723a9) 97.39% compared to head (6e55999) 97.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3413      +/-   ##
==========================================
- Coverage   97.39%   97.30%   -0.10%     
==========================================
  Files         233      233              
  Lines       48174    48192      +18     
==========================================
- Hits        46921    46893      -28     
- Misses       1253     1299      +46     
Flag Coverage Δ
linux 97.30% <100.00%> (+0.02%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@invisig0th invisig0th changed the title WIP: Allow setting layers on a root view with forks Allow setting layers on a root view with forks Nov 7, 2023
Copy link
Contributor

@MichaelSquires MichaelSquires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed

MichaelSquires
MichaelSquires previously approved these changes Nov 7, 2023
Copy link
Contributor

@MichaelSquires MichaelSquires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch on the layer ordering in your last commit!

@vEpiphyte vEpiphyte added this to the v2.15x.x milestone Nov 14, 2023
@vEpiphyte vEpiphyte added enhancement reqChangelog requires changelog labels Nov 14, 2023
@invisig0th invisig0th merged commit 97a32b1 into master Nov 14, 2023
@invisig0th invisig0th deleted the visi-view-setlayers branch November 14, 2023 20:32
@vEpiphyte vEpiphyte modified the milestones: v2.15x.x, v2.154.0 Nov 14, 2023
@vEpiphyte vEpiphyte removed the reqChangelog requires changelog label Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants