Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise an error when attempting an invalid PivotInFrom operation (SYN-6474) #3426

Merged
merged 7 commits into from
Nov 17, 2023

Conversation

Cisphyx
Copy link
Contributor

@Cisphyx Cisphyx commented Nov 16, 2023

No description provided.

@Cisphyx Cisphyx changed the title Raise an error when attempting an invalid PivotInFrom (SYN-6474) Raise an error when attempting an invalid PivotInFrom operation (SYN-6474) Nov 16, 2023
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c643ea4) 97.40% compared to head (1feb492) 97.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3426      +/-   ##
==========================================
- Coverage   97.40%   97.30%   -0.11%     
==========================================
  Files         233      233              
  Lines       48332    48333       +1     
==========================================
- Hits        47079    47030      -49     
- Misses       1253     1303      +50     
Flag Coverage Δ
linux 97.30% <100.00%> (-0.01%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

synapse/lib/ast.py Outdated Show resolved Hide resolved
@vEpiphyte vEpiphyte added this to the v2.15x.x milestone Nov 17, 2023
@Cisphyx Cisphyx merged commit 713def1 into master Nov 17, 2023
@Cisphyx Cisphyx deleted the pivot-in-err branch November 17, 2023 18:39
@vEpiphyte vEpiphyte removed the reqChangelog requires changelog label Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants