Add risk:technique:masquerade form #3438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3438 +/- ##
==========================================
- Coverage 97.40% 97.31% -0.10%
==========================================
Files 233 233
Lines 48362 48362
==========================================
- Hits 47109 47063 -46
- Misses 1253 1299 +46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
MichaelSquires
approved these changes
Nov 27, 2023
| @@ -942,6 +944,16 @@ def getModelDefs(self): | |||
| 'doc': 'The currency in which payment was demanded.'}), | |||
|
|
|||
| )), | |||
| ('risk:technique:masquerade', {}, ( | |||
| ('node', ('ndef', {}), { | |||
There was a problem hiding this comment.
Is ndef pretty well understood? Maybe an ex on this prop?
There was a problem hiding this comment.
We can break out a form sub for these two ndef properties
Cisphyx
approved these changes
Nov 27, 2023
vEpiphyte
reviewed
Nov 27, 2023
| @@ -942,6 +944,16 @@ def getModelDefs(self): | |||
| 'doc': 'The currency in which payment was demanded.'}), | |||
|
|
|||
| )), | |||
| ('risk:technique:masquerade', {}, ( | |||
There was a problem hiding this comment.
Do we need a reporter property here?
There was a problem hiding this comment.
No, it would be appropriate to use a <(seen)- meta:source here but reporter properties are typically for more abstract concepts. 👍
vEpiphyte
added
model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.