Skip to content

SYN-6353: cron status changes through nexus #3460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Dec 15, 2023

Conversation

MichaelSquires
Copy link
Contributor

@MichaelSquires MichaelSquires commented Dec 8, 2023

feat: Update cron attributes via nexus so state changes are propagated to cortex mirrors.
bugfix: Fix a bug where editing a cron job name or doc via syn:cron edits would not be reflected in a mirror until restart.

- bugfix: Fix bug where cron jobs weren't being properly updated when changing name/doc values via syn:cron.
- feat: Move cron definition schema to s_schemas.
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8040b81) 97.57% compared to head (a42e2c6) 97.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3460      +/-   ##
==========================================
- Coverage   97.57%   97.49%   -0.09%     
==========================================
  Files         233      233              
  Lines       48067    48058       -9     
==========================================
- Hits        46903    46855      -48     
- Misses       1164     1203      +39     
Flag Coverage Δ
linux 97.49% <100.00%> (-0.01%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelSquires MichaelSquires marked this pull request as ready for review December 8, 2023 20:50
@vEpiphyte vEpiphyte added enhancement reqChangelog requires changelog labels Dec 13, 2023
@MichaelSquires MichaelSquires merged commit ba04308 into master Dec 15, 2023
@MichaelSquires MichaelSquires deleted the blackout/SYN-6353/cron-state branch December 15, 2023 18:29
@vEpiphyte vEpiphyte added this to the v2.15x.x milestone Dec 20, 2023
@vEpiphyte vEpiphyte removed the reqChangelog requires changelog label Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants