Skip to content

SYN-6604: vault API to replace configs/secrets #3461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

MichaelSquires
Copy link
Contributor

feat: Add API to replace vault configs/secrets

Copy link

codecov bot commented Dec 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5aee904) 97.60% compared to head (34f2457) 97.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3461      +/-   ##
==========================================
- Coverage   97.60%   97.51%   -0.10%     
==========================================
  Files         233      233              
  Lines       48024    48062      +38     
==========================================
- Hits        46876    46866      -10     
- Misses       1148     1196      +48     
Flag Coverage Δ
linux 97.51% <100.00%> (-0.01%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vEpiphyte vEpiphyte added this to the v2.15x.x milestone Dec 11, 2023
vEpiphyte
vEpiphyte previously approved these changes Dec 11, 2023
Base automatically changed from blackout/SYN-5887/vaults to master December 11, 2023 21:39
@MichaelSquires MichaelSquires dismissed vEpiphyte’s stale review December 11, 2023 21:39

The base branch was changed.

@MichaelSquires MichaelSquires merged commit 23b75c9 into master Dec 12, 2023
@MichaelSquires MichaelSquires deleted the blackout/SYN-6604/vaults-replace-configs-secrets branch December 12, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants