WIP: Context menus to master #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FormChild.cs: + Open menu works now + Open file location works now, it opens up a explorer.exe shell to select the file. + Run as administrator works if you're above NT 6.0 * Renamed "Cut" to "Move icon to..." Not functinal yet. [note 1] * Renamed "Copy" to "Copy icon to..." Not functinal yet. [note 1] - Deleted "Paste" menu item + Added new menu when you did not select anything, so you can add a item. note 1: This will open up a new form where you can choose where to copy/move the icon to. FromProperties.cs: + WIP: Properties dialog where you also can change the icon.
…rows an exception
When making a new group and right clicking with no items will cause a nullpointerexception. This commit checks if the focuesed item is null. Signed-off-by: marfjeh <git@marfprojects.nl>
- Removed redunded FormProperties. Signed-off-by: marfjeh <git@marfprojects.nl>
+ Added a properties menu entry when right clicking in the mdichild to rename the mdichild. * Changed line break from FormMain to CRLF as visual studio was complainging/crying about it - Disabled the non-functional "Copy to" and "Move to" Menu entries as i'm going need making a new form for this. Problems found: When a icon entry gets deleted from the system, it does not get removed in the database, and at every start it will complain about it. Signed-off-by: marfjeh <git@marfprojects.nl>
… feature/contextmenu Signed-off-by: marfjeh <git@marfprojects.nl>
Signed-off-by: marfjeh <git@marfprojects.nl>
…ound. Signed-off-by: marfjeh <git@marfprojects.nl>
Signed-off-by: marfjeh <git@marfprojects.nl>
|
Thank you for this PR! This does really brings back that experience from 90s! Sadly, I no longer use C# and Visual Studio, so i can give you access to commit changes directly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I never realized you did merge some of my changes to your repo. :D
As this is still kind of a Work in Progress, most of the context menus are implemented, I committed some of the changes I never pushed to GitHub, and after a year of using it, as I use this program for my Windows VM on Linux it is very useful.
Only that is not implemented yet are the copy and move actions.
For the copy and move, I'm going to make a new Form that will closely reassemble the one in Windows 3.x. (without the 3.x title bar)
For this, I will make another branch and merge it to this branch so you can merge this in 1 go.
If you want, and I will leave that up to you, you can already merge this branch as most of the features are now functional except for copy and move. If you do and when I implemented the copy and move commands then I'll make a new PR if you want.
some of the planned things:
Thanks!