From 2c447a9d80314a912a9d77b54cb39b847cfad9ab Mon Sep 17 00:00:00 2001
From: "hs.zhang" <22708345+cangfengzhs@users.noreply.github.com>
Date: Wed, 23 Nov 2022 18:48:32 +0800
Subject: [PATCH] fix update config (#4915)

---
 src/common/meta/GflagsManager.cpp | 9 ++++++---
 tests/admin/test_configs.py       | 2 +-
 2 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/src/common/meta/GflagsManager.cpp b/src/common/meta/GflagsManager.cpp
index 58ae066a502..24c63104ceb 100644
--- a/src/common/meta/GflagsManager.cpp
+++ b/src/common/meta/GflagsManager.cpp
@@ -196,11 +196,14 @@ std::string GflagsManager::ValueToGflagString(const Value& val) {
       std::transform(kvs.begin(), kvs.end(), values.begin(), [](const auto& iter) -> std::string {
         std::stringstream out;
         out << "\"" << iter.first << "\""
-            << ":"
-            << "\"" << iter.second << "\"";
+            << ":";
+        if (iter.second.isStr() || iter.second.isBool()) {
+          out << iter.second;
+        } else {
+          out << "\"" << iter.second << "\"";
+        }
         return out.str();
       });
-
       std::stringstream os;
       os << "{" << folly::join(",", values) << "}";
       return os.str();
diff --git a/tests/admin/test_configs.py b/tests/admin/test_configs.py
index 8a28bd1c79b..e100d275ba1 100644
--- a/tests/admin/test_configs.py
+++ b/tests/admin/test_configs.py
@@ -120,7 +120,7 @@ def test_configs(self):
         resp = self.client.execute('''
                                    UPDATE CONFIGS storage:rocksdb_column_family_options={
                                    max_bytes_for_level_base="268435456",
-                                   write_buffer_size="67108864",
+                                   write_buffer_size="33554432",
                                    max_write_buffer_number="4"}
                                    ''')
         self.check_resp_succeeded(resp)