Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can tag name be identical to an edge type name within the same space #598

Closed
jude-zhu opened this issue Jul 9, 2019 · 1 comment

Comments

@jude-zhu
Copy link
Contributor

commented Jul 9, 2019

I defined an edge type named player2 , then created a tag named player2 in the same space successfully.

image

Should the name be unique within one space?

@sherman-the-tank

This comment has been minimized.

Copy link
Member

commented Jul 10, 2019

Good point 👍

I don't think we should allow tag name and edge type to share the same name.

One solution is to let the meta service check during the creation and return error if the name has been used

@dangleptr

@sherman-the-tank sherman-the-tank added this to the R201910_beta milestone Jul 10, 2019

@laura-ding laura-ding self-assigned this Jul 17, 2019

laura-ding added a commit to laura-ding/nebula that referenced this issue Jul 18, 2019

laura-ding added a commit to laura-ding/nebula that referenced this issue Jul 18, 2019

laura-ding added a commit to laura-ding/nebula that referenced this issue Jul 23, 2019

laura-ding added a commit to laura-ding/nebula that referenced this issue Jul 26, 2019

laura-ding added a commit to laura-ding/nebula that referenced this issue Aug 1, 2019

@dutor dutor closed this in #652 Aug 2, 2019

dutor added a commit that referenced this issue Aug 2, 2019

Fix the same name tag and edge in same space #598 (#652)
* Fix the same name tag and edge in same space #598

* Fix show tags or edges have many same tags or edge #650

* Address dutor's comment

* Rebase upstream

* Modify default install path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.