Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support id in show tags and show edges #1207

Merged
merged 3 commits into from
Nov 7, 2019
Merged

Support id in show tags and show edges #1207

merged 3 commits into from
Nov 7, 2019

Conversation

darionyaphet
Copy link
Contributor

@darionyaphet darionyaphet commented Nov 5, 2019 •
edited
Loading 

(user@127.0.0.1) [t]> show tags
=================
| ID | Name     |
=================
| 2  | course   |
-----------------
| 3  | building |
-----------------
| 4  | student  |
-----------------
Got 3 rows (Time spent: 1784/2755 us)

(user@127.0.0.1) [t]> show edges
===============
| ID | Name   |
===============
| 5  | like   |
---------------
| 6  | select |
---------------
Got 2 rows (Time spent: 1519/2359 us)

@zhangguoqing
Copy link
Contributor

LGTM! It's very useful, and close #1206

@CPWstatic
Copy link
Contributor

Did you run tests offline? It seems that UT would failed if you just change the return value without modify the corresponding UT.

@dangleptr dangleptr added the ready-for-testing PR: ready for the CI test label Nov 5, 2019
@dangleptr
Copy link
Contributor

Jenkins go

@nebula-community-bot
Copy link
Member

Unit testing failed.

@nebula-community-bot
Copy link
Member

Unit testing passed.

critical27
critical27 approved these changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@critical27 critical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. LGTM

@nebula-community-bot
Copy link
Member

Unit testing passed.

@dangleptr dangleptr merged commit 90ee9d7 into vesoft-inc:master Nov 7, 2019
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Feb 16, 2020
@dangleptr
support id in show tags and show edges (vesoft-inc#1207)
c19dcb7
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
@dangleptr
support id in show tags and show edges (vesoft-inc#1207)
5d3734d
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Jan 31, 2023
@nebula-bots @critical27 @wenhaocs
fix invalid filter in GetProp make storage crashed (vesoft-inc#1207)
c9b31fb 
Co-authored-by: haowen <19355821+wenhaocs@users.noreply.github.com>

Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com>
Co-authored-by: haowen <19355821+wenhaocs@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amber-moe amber-moe amber-moe left review comments

@critical27 critical27 critical27 approved these changes

@dangleptr dangleptr dangleptr approved these changes

@dutor dutor Awaiting requested review from dutor

@CPWstatic CPWstatic Awaiting requested review from CPWstatic

@whitewum whitewum Awaiting requested review from whitewum

@liuyu85cn liuyu85cn Awaiting requested review from liuyu85cn

@laura-ding laura-ding Awaiting requested review from laura-ding

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@darionyaphet @zhangguoqing @CPWstatic @dangleptr @nebula-community-bot @critical27 @amber-moe @laura-ding