Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return variable if not empty #1233

Merged
merged 6 commits into from Nov 21, 2019
Merged

Return variable if not empty #1233

merged 6 commits into from Nov 21, 2019

Conversation

CPWstatic
Copy link
Contributor

@CPWstatic CPWstatic commented Nov 7, 2019

The return sentence is used for returning variable if it is not empty.

We have CN-docs with pr #1246

@CPWstatic CPWstatic added the ready-for-testing PR: ready for the CI test label Nov 7, 2019
@nebula-community-bot
Copy link
Member

nebula-community-bot commented Nov 7, 2019

Unit testing failed.

@CPWstatic
Copy link
Contributor Author

CPWstatic commented Nov 8, 2019

Jenkins go!

@nebula-community-bot
Copy link
Member

nebula-community-bot commented Nov 8, 2019

Unit testing failed.

@nebula-community-bot
Copy link
Member

nebula-community-bot commented Nov 8, 2019

Unit testing failed.

@nebula-community-bot
Copy link
Member

nebula-community-bot commented Nov 8, 2019

Unit testing passed.

src/graph/ReturnExecutor.cpp Outdated Show resolved Hide resolved
src/graph/ReturnExecutor.h Outdated Show resolved Hide resolved
@nebula-community-bot
Copy link
Member

nebula-community-bot commented Nov 11, 2019

Unit testing passed.

@nebula-community-bot
Copy link
Member

nebula-community-bot commented Nov 15, 2019

Unit testing passed.

@jude-zhu jude-zhu requested review from monadbobo and laura-ding Nov 15, 2019
src/parser/ProcessControlSentences.cpp Show resolved Hide resolved
src/parser/parser.yy Outdated Show resolved Hide resolved
@nebula-community-bot
Copy link
Member

nebula-community-bot commented Nov 19, 2019

Unit testing passed.

@zhangguoqing
Copy link
Contributor

zhangguoqing commented Nov 20, 2019

LGTM!

dutor
dutor approved these changes Nov 21, 2019
Copy link
Contributor

@dutor dutor left a comment

LGTM.

@nebula-community-bot
Copy link
Member

nebula-community-bot commented Nov 21, 2019

Unit testing passed.

@dutor dutor merged commit 317203f into vesoft-inc:master Nov 21, 2019
@jude-zhu
Copy link
Contributor

jude-zhu commented Nov 29, 2019

relate to #174

yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Feb 16, 2020
* Add return sentence.

* Add test.

* Address comment and add more tests.

* Rebase and fix conflict.

* Update.
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
* Add return sentence.

* Add test.

* Address comment and add more tests.

* Rebase and fix conflict.

* Update.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants