Balance stop #1238
Merged
Balance stop #1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
critical27
requested review from
darionyaphet,
CPWstatic,
dangleptr,
laura-ding,
liuyu85cn and
bright-starry-sky
|
Jenkins go |
dangleptr
reviewed
Nov 8, 2019
|
Unit testing passed. |
3 similar comments
|
Unit testing passed. |
|
Unit testing passed. |
|
Unit testing passed. |
dangleptr
reviewed
Nov 11, 2019
|
Unit testing failed. |
|
Unit testing passed. |
|
Jenkins go |
|
Unit testing passed. |
|
Unit testing passed. |
darionyaphet
reviewed
Nov 12, 2019
darionyaphet
approved these changes
Nov 12, 2019
|
Great work！ |
|
Unit testing passed. |
|
close #1032 |
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Feb 16, 2020
* balance stop * address dangleptr's comments * update log, fix ut
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
* balance stop * address dangleptr's comments * update log, fix ut
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
We can run balance data stop in console. Just like balance data, it will return running balance plan id (if no valid plan running, an error is returned). You can check the status by balance data id. Once remaining tasks has finished, you can trigger the plan by balance data to continue all tasks stopped previously.