Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc]Add return doc. #1246

Merged
merged 2 commits into from Nov 21, 2019
Merged

[doc]Add return doc. #1246

merged 2 commits into from Nov 21, 2019

Conversation

CPWstatic
Copy link
Contributor

@CPWstatic CPWstatic commented Nov 11, 2019

No description provided.

@Amber1990Zhang Amber1990Zhang changed the title Add return doc. [doc]Add return doc. Nov 11, 2019
Copy link
Contributor

@Amber1990Zhang Amber1990Zhang left a comment

LGTM. Thank you for this brilliant new function and doc. I'll take care of the minor errors.


# 示例

```
Copy link
Contributor

@Amber1990Zhang Amber1990Zhang Nov 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

````ngql`

# 示例

```
(user@127.0.0.1) [myspace_test2]> $A = GO FROM 200 OVER like YIELD like._dst AS dst; \
Copy link
Contributor

@Amber1990Zhang Amber1990Zhang Nov 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nebula>...

Copy link
Contributor

@whitewum whitewum Nov 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree

(user@127.0.0.1) [myspace_test2] is too long & meanless to read. can you just modify to

nebula>

# 示例

```
(user@127.0.0.1) [myspace_test2]> $A = GO FROM 200 OVER like YIELD like._dst AS dst; \
Copy link
Contributor

@whitewum whitewum Nov 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree

(user@127.0.0.1) [myspace_test2] is too long & meanless to read. can you just modify to

nebula>

# 示例

```
(user@127.0.0.1) [myspace_test2]> $A = GO FROM 200 OVER like YIELD like._dst AS dst; \
Copy link
Contributor

@whitewum whitewum Nov 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is your style for variable? Upper case or lower case?

why $A and $rA?

Return 语句用于返回条件成立时的结果。

```ngql
RETURN <var_ref> IF <var_ref> IS NOT NULL
Copy link
Contributor

@whitewum whitewum Nov 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you support IS NULL also? or only IS NOT NULL.

-> $rA = YIELD $A.* WHERE $A.dst == 201; \
-> RETURN $rA IF $rA is NOT NULL; \ /* return here since $rA is not empty */
-> GO FROM $A.dst OVER like; /* will never be executed*/
Copy link
Contributor

@Amber1990Zhang Amber1990Zhang Nov 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

                           ->            remove spaces and -> 

indent

@Amber1990Zhang Amber1990Zhang requested a review from laura-ding Nov 13, 2019
@dutor dutor added the ready-for-testing PR: ready for the CI test label Nov 21, 2019
@dutor
Copy link
Contributor

dutor commented Nov 21, 2019

Jenkins go!

@nebula-community-bot
Copy link
Member

nebula-community-bot commented Nov 21, 2019

Unit testing passed.

1 similar comment
@nebula-community-bot
Copy link
Member

nebula-community-bot commented Nov 21, 2019

Unit testing passed.

@dutor dutor merged commit 8efe01a into vesoft-inc:master Nov 21, 2019
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants