Support vertex cache on storage side #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangleptr
requested review from
darionyaphet,
zhangguoqing,
zlcook,
CPWstatic,
critical27,
whitewum,
liuyu85cn and
bright-starry-sky
|
Unit testing passed. |
|
Unit testing passed. |
darionyaphet
reviewed
Nov 20, 2019
| @@ -27,6 +27,9 @@ | |||
| processor->process(req); \ | |||
| return f; | |||
|
|
|||
| DEFINE_int32(vertex_cache_num, 16 * 1000 * 1000, "Total keys inside the cache"); | |||
| DEFINE_int32(vertex_cache_bucket_exp, 4, "Total buckets number is 1 << cache_bucket_exp"); | |||
critical27
reviewed
Nov 20, 2019
|
Unit testing passed. |
bright-starry-sky
reviewed
Nov 22, 2019
|
Unit testing passed. |
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
* Support vertex cache * Add internal check * Address cirtical's comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Hope it could be helpful in your case. @CPWstatic