Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check pid before init glog #2278

Merged
merged 2 commits into from Aug 7, 2020
Merged

check pid before init glog #2278

merged 2 commits into from Aug 7, 2020

Conversation

liuyu85cn
Copy link
Contributor

@liuyu85cn liuyu85cn commented Aug 7, 2020

Meet an error:

Try to start all daemon twice.

The second one will failed, and said

'process already existed'.

But the first one can't output log any more.

@liuyu85cn liuyu85cn added the ready-for-testing PR: ready for the CI test label Aug 7, 2020
dangleptr
dangleptr previously approved these changes Aug 7, 2020
Copy link
Contributor

@dangleptr dangleptr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

Copy link
Contributor

@panda-sheep panda-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@dangleptr dangleptr merged commit a5275b1 into vesoft-inc:master Aug 7, 2020
xuguruogu pushed a commit to xuguruogu/nebula that referenced this pull request Sep 12, 2020
* check pid before init glog

* compile error
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
* check pid before init glog

* compile error
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Jan 31, 2023
* Add some tests about yield.

* Add more tests.

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

Co-authored-by: shylock <33566796+Shylock-Hg@users.noreply.github.com>
Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants