Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the source tree #41

Merged
merged 1 commit into from Dec 16, 2018

Conversation

@dutor
Copy link
Member

commented Dec 16, 2018

This PR is to refactor the source tree:

  • Put all source directories into the src directory.
  • Add src/daemons directory to host the source files of our several service executables. Here I sugguest to name our daemons as nebula-graphd, nebula-storaged, and nebula-metad.
  • Add etc and scripts to host configuration files and scripts.
  • Rename the top level namespace from vesoft to nebula, and the three kinds of services use their own namespaces, i.e. graph, meta and storage.
  • Add an empty README file in each primary module's directory.
  • Add a cmake option THIRD_PARTY_JOBS, to allow us to customize the concurrency level of the third-party build.
  • Add -Wunused-param.
  • Move the global -Wno-error=sign-compare option into sub-directory src/parser.
  • Other mechanical changes.

@dutor dutor requested review from sherman-the-tank and dangleptr Dec 16, 2018

@nebula-community-bot

This comment has been minimized.

Copy link
Member

commented Dec 16, 2018

Build failed.

@dutor

This comment has been minimized.

Copy link
Member Author

commented Dec 16, 2018

It seems due to failure of third-party. jenkins rerun tests please.

@nebula-community-bot

This comment has been minimized.

Copy link
Member

commented Dec 16, 2018

Build failed.

@dutor

This comment has been minimized.

Copy link
Member Author

commented Dec 16, 2018

jenkins, run tests

@nebula-community-bot

This comment has been minimized.

Copy link
Member

commented Dec 16, 2018

Build failed.

@dutor

This comment has been minimized.

Copy link
Member Author

commented Dec 16, 2018

Related configurations of Jenkins need to be adjusted. Now jenkins please run tests.

@nebula-community-bot

This comment has been minimized.

Copy link
Member

commented Dec 16, 2018

Build succeeded.

1 similar comment
@nebula-community-bot

This comment has been minimized.

Copy link
Member

commented Dec 16, 2018

Build succeeded.

@sherman-the-tank
Copy link
Member

left a comment

Whoa!! Hats off to the big effort

LGTM! Nicely done 👍

@@ -35,6 +35,10 @@ set(CMAKE_CXX_STANDARD 14)

set(CMAKE_EXE_LINKER_FLAGS "-static-libstdc++")

if (NOT THIRD_PARTY_JOBS)

This comment has been minimized.

Copy link
@sherman-the-tank
@@ -80,6 +80,7 @@ int32_t ResultSchemaProvider::getFieldIndex(const folly::StringPiece name,

const char* ResultSchemaProvider::getFieldName(int32_t index,
int32_t ver) const {
UNUSED(ver);

This comment has been minimized.

Copy link
@sherman-the-tank

@sherman-the-tank sherman-the-tank merged commit 57b1282 into vesoft-inc:master Dec 16, 2018

1 check passed

Jenkins All tests passed.
Details

@dutor dutor deleted the dutor:src-infra-refactor branch Dec 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.