From 3ca373702c7bf0f87aef695d2162cc5309c12902 Mon Sep 17 00:00:00 2001 From: jievince <38901892+jievince@users.noreply.github.com> Date: Thu, 24 Nov 2022 16:22:44 +0800 Subject: [PATCH] fix argument --- src/graph/executor/logic/ArgumentExecutor.cpp | 4 +++- src/graph/planner/match/MatchPathPlanner.cpp | 6 +++--- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/graph/executor/logic/ArgumentExecutor.cpp b/src/graph/executor/logic/ArgumentExecutor.cpp index 941690efab0..0909c9fce65 100644 --- a/src/graph/executor/logic/ArgumentExecutor.cpp +++ b/src/graph/executor/logic/ArgumentExecutor.cpp @@ -25,7 +25,9 @@ folly::Future ArgumentExecutor::execute() { for (; iter->valid(); iter->next()) { auto val = iter->getColumn(alias); if (!val.isVertex()) { - continue; + return Status::Error("Argument only support vertex, but got %s, which is type %s, ", + val.toString().c_str(), + val.typeName().c_str()); } if (unique.emplace(val.getVertex().vid).second) { Row row; diff --git a/src/graph/planner/match/MatchPathPlanner.cpp b/src/graph/planner/match/MatchPathPlanner.cpp index f0160a5c9a4..3bda375145a 100644 --- a/src/graph/planner/match/MatchPathPlanner.cpp +++ b/src/graph/planner/match/MatchPathPlanner.cpp @@ -118,9 +118,9 @@ Status MatchPathPlanner::findStarts( allNodeAliasesAvailable.merge(nodeAliasesSeen); std::for_each( aliasesAvailable.begin(), aliasesAvailable.end(), [&allNodeAliasesAvailable](auto& kv) { - if (kv.second == AliasType::kNode) { - allNodeAliasesAvailable.emplace(kv.first); - } + // if (kv.second == AliasType::kNode) { + allNodeAliasesAvailable.emplace(kv.first); + // } }); // Find the start plan node