New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove third party #538
Remove third party #538
Conversation
Unit testing failed. |
CMakeLists.txt
Outdated
list(INSERT CMAKE_INCLUDE_PATH 0 ${NEBULA_BZIP2_ROOT}/include) | ||
list(INSERT CMAKE_LIBRARY_PATH 0 ${NEBULA_BZIP2_ROOT}/lib) | ||
list(INSERT CMAKE_PROGRAM_PATH 0 ${NEBULA_BZIP2_ROOT}/bin) | ||
endif() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Newly added options, please add a comment at the beginning of the file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good advice
cmake/FindFatal.cmake
Outdated
# | ||
# Fatal_FOUND System has readline, include and lib dirs found | ||
# Fatal_INCLUDE_DIR The readline includes directories. | ||
# Fatal_LIBRARY The readline library. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not use?
cmake/FindFbthrift.cmake
Outdated
# Fbthrift_INCLUDE_DIR The fbthrift includes directories. | ||
# Fbthrift_LIBRARY The fbthrift library. | ||
# Fbthrift_BIN The fbthrift binary. | ||
# Fbthrift_VERSION The fbthrift version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not use?
jenkins go |
Unit testing passed. |
2 similar comments
Unit testing passed. |
Unit testing passed. |
Jenkins, please run tests. |
Unit testing failed. |
|
Unit testing passed. |
* Remove third-party * Modify fbthrift java jar path * Encapsulation generated thrift obj * Support to compile to the specified dir * Rebase upstream * Rebase upstream * Modify third-party root * add base_obj depends on meta_thrift_obj
* Remove third-party * Modify fbthrift java jar path * Encapsulation generated thrift obj * Support to compile to the specified dir * Rebase upstream * Rebase upstream * Modify third-party root * add base_obj depends on meta_thrift_obj
The packages of the third party are doing.