Skip to content

Conversation

@nevermore3
Copy link
Contributor

@nevermore3 nevermore3 commented Aug 15, 2023

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

close https://github.com/vesoft-inc/nebula-ent/issues/2992

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +1.19% 🎉

Comparison is base (d0086dd) 77.06% compared to head (d590a1c) 78.25%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5674      +/-   ##
==========================================
+ Coverage   77.06%   78.25%   +1.19%     
==========================================
  Files        1133     1133              
  Lines       85769    85778       +9     
==========================================
+ Hits        66095    67126    +1031     
+ Misses      19674    18652    -1022     
Files Changed Coverage Δ
src/graph/validator/SetValidator.h 100.00% <ø> (ø)
src/graph/validator/SetValidator.cpp 96.55% <100.00%> (+0.80%) ⬆️

... and 95 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nevermore3 nevermore3 added ready-for-testing PR: ready for the CI test ready for review and removed ready-for-testing PR: ready for the CI test ready for review labels Aug 15, 2023
@Sophie-Xie Sophie-Xie merged commit 18813f3 into vesoft-inc:master Aug 16, 2023
@nevermore3 nevermore3 deleted the fix_union branch August 16, 2023 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review ready-for-testing PR: ready for the CI test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants