Skip to content

each group applies a rule only once#5734

Merged
Sophie-Xie merged 3 commits intovesoft-inc:masterfrom
nevermore3:fix_optimizer
Oct 10, 2023
Merged

each group applies a rule only once#5734
Sophie-Xie merged 3 commits intovesoft-inc:masterfrom
nevermore3:fix_optimizer

Conversation

@nevermore3
Copy link
Contributor

@nevermore3 nevermore3 commented Oct 8, 2023

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

close https://github.com/vesoft-inc/nebula-ent/issues/3052

Description:

The execution plan tree is a DAG
In the optimizer phase, checkPlanDepth, explore, getPlan, pruneProperties and analyzeLifetime in the scheduling phase will recursively traverse the execution plan tree, and nodes that have been visited will be visited again.

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@nevermore3 nevermore3 force-pushed the fix_optimizer branch 2 times, most recently from 4c3cead to 8def78a Compare October 9, 2023 03:55
@Sophie-Xie Sophie-Xie merged commit 213dfa0 into vesoft-inc:master Oct 10, 2023
@nevermore3 nevermore3 deleted the fix_optimizer branch October 10, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review ready-for-testing PR: ready for the CI test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants