Reduce the blocking time of the write lock when deleting space#5754
Merged
critical27 merged 4 commits intovesoft-inc:masterfrom Nov 15, 2023
Merged
Reduce the blocking time of the write lock when deleting space#5754critical27 merged 4 commits intovesoft-inc:masterfrom
critical27 merged 4 commits intovesoft-inc:masterfrom
Conversation
When the number of parts of a space is relatively large and the amount of data written is also large, it will block for a long time in the removeSpace function when deleting the space. Affect business read and write
Reduce the blocking time of the write lock when deleting space
Contributor
|
Wow, thanks @flymysql for the great contribution. |
Resolve compilation issues
SuperYoko
reviewed
Nov 13, 2023
SuperYoko
approved these changes
Nov 13, 2023
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5754 +/- ##
==========================================
+ Coverage 77.10% 78.25% +1.14%
==========================================
Files 1133 1133
Lines 85968 85994 +26
==========================================
+ Hits 66288 67291 +1003
+ Misses 19680 18703 -977 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Cheers! @critical27 @flymysql @SuperYoko |
critical27
approved these changes
Nov 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
#5755
Description:
When the number of parts of a space is relatively large and the amount of data written is also large, it will block for a long time in the removeSpace function when deleting the space. Affect business read and write
How do you solve it?
Shorten the range of holding locks
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: