Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed or adjusted permissions on installed files #578

Merged
merged 3 commits into from Jul 19, 2019

Conversation

@dutor
Copy link
Member

commented Jul 3, 2019

As title.

@nebula-community-bot

This comment has been minimized.

Copy link

commented Jul 8, 2019

Unit testing passed.

FILES
utils.sh
PERMISSIONS
OWNER_WRITE OWNER_READ

This comment has been minimized.

Copy link
@monadbobo

monadbobo Jul 12, 2019

Contributor

why utils.sh does not need executable permissions here?

This comment has been minimized.

Copy link
@dutor

dutor Jul 14, 2019

Author Member

As its name indicating, this is a collection of utilities, so the file is not going to be executed directly.

@laura-ding
Copy link
Contributor

left a comment

Well done

@nebula-community-bot

This comment has been minimized.

Copy link

commented Jul 19, 2019

Unit testing passed.

@dutor dutor merged commit 1df8375 into vesoft-inc:master Jul 19, 2019

1 check passed

UnitTest All tests passed.
Details

@dutor dutor deleted the dutor:fix-permissions branch Jul 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.