Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement groupby #749

Merged
merged 11 commits into from Nov 12, 2019
Merged

Implement groupby #749

merged 11 commits into from Nov 12, 2019

Conversation

laura-ding
Copy link
Contributor

@laura-ding laura-ding commented Aug 9, 2019

Closes #676

@laura-ding laura-ding added the ready-for-testing PR: ready for the CI test label Aug 12, 2019
@jude-zhu jude-zhu requested review from CPWstatic, dutor and whitewum Aug 12, 2019
@laura-ding laura-ding mentioned this pull request Aug 13, 2019
Copy link
Contributor

@whitewum whitewum left a comment

Great Job

src/parser/test/ParserTest.cpp Show resolved Hide resolved
src/parser/test/ParserTest.cpp Show resolved Hide resolved
src/parser/test/ParserTest.cpp Show resolved Hide resolved
src/graph/test/GroupByLimitTest.cpp Outdated Show resolved Hide resolved
src/graph/test/GroupByLimitTest.cpp Outdated Show resolved Hide resolved
src/graph/AggregateFunction.h Outdated Show resolved Hide resolved
src/common/filter/Expressions.cpp Show resolved Hide resolved
src/graph/GroupByExecutor.cpp Outdated Show resolved Hide resolved
src/graph/GroupByExecutor.cpp Show resolved Hide resolved
src/graph/GroupByExecutor.cpp Show resolved Hide resolved
src/graph/GroupByExecutor.cpp Show resolved Hide resolved
src/graph/GroupByExecutor.cpp Outdated Show resolved Hide resolved
@nebula-community-bot
Copy link
Member

nebula-community-bot commented Sep 16, 2019

Unit testing passed.

Copy link
Contributor

@CPWstatic CPWstatic left a comment

Please resolve the conflict.

@nebula-community-bot
Copy link
Member

nebula-community-bot commented Sep 24, 2019

Unit testing passed.

@nebula-community-bot
Copy link
Member

nebula-community-bot commented Sep 30, 2019

Unit testing failed.

@laura-ding
Copy link
Contributor Author

laura-ding commented Sep 30, 2019

jenkins go

@nebula-community-bot
Copy link
Member

nebula-community-bot commented Sep 30, 2019

Unit testing passed.

3 similar comments
@nebula-community-bot
Copy link
Member

nebula-community-bot commented Oct 23, 2019

Unit testing passed.

@nebula-community-bot
Copy link
Member

nebula-community-bot commented Oct 23, 2019

Unit testing passed.

@nebula-community-bot
Copy link
Member

nebula-community-bot commented Oct 24, 2019

Unit testing passed.

@jude-zhu jude-zhu added this to the R201910_RC1 milestone Oct 28, 2019
src/graph/AggregateFunction.h Outdated Show resolved Hide resolved
@nebula-community-bot
Copy link
Member

nebula-community-bot commented Nov 4, 2019

Unit testing passed.

src/graph/AggregateFunction.h Outdated Show resolved Hide resolved
Copy link
Contributor

@CPWstatic CPWstatic left a comment

Good job! I had make some inline comment.

src/graph/Executor.cpp Outdated Show resolved Hide resolved
src/graph/YieldExecutor.cpp Outdated Show resolved Hide resolved
src/graph/YieldExecutor.cpp Outdated Show resolved Hide resolved
src/graph/GroupByExecutor.cpp Outdated Show resolved Hide resolved
src/graph/GroupByExecutor.cpp Outdated Show resolved Hide resolved
src/graph/GroupByExecutor.cpp Outdated Show resolved Hide resolved
src/graph/AggregateFunction.h Outdated Show resolved Hide resolved
src/graph/GroupByExecutor.cpp Show resolved Hide resolved
src/graph/GroupByExecutor.cpp Outdated Show resolved Hide resolved
src/graph/GroupByExecutor.cpp Outdated Show resolved Hide resolved
src/graph/YieldExecutor.cpp Outdated Show resolved Hide resolved
@vesoft-inc vesoft-inc deleted a comment from CPWstatic Nov 4, 2019
@nebula-community-bot
Copy link
Member

nebula-community-bot commented Nov 4, 2019

Unit testing passed.

dutor
dutor approved these changes Nov 12, 2019
Copy link
Contributor

@dutor dutor left a comment

LGTM.

@nebula-community-bot
Copy link
Member

nebula-community-bot commented Nov 12, 2019

Unit testing passed.

@dutor dutor merged commit efe12c9 into vesoft-inc:master Nov 12, 2019
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Feb 16, 2020
* Implement group by

* Add stdev, bit_and, bit_or, bit_xor

* Rebase upstream

* Address comments and rebase upstream

* rebase master

* Rebase upstream

* Improve the implementation

* Fix yield col not in group cols

* support aggregation in YIELD

* Address CPWstatic and liuyu85cn's comments
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
* Implement group by

* Add stdev, bit_and, bit_or, bit_xor

* Rebase upstream

* Address comments and rebase upstream

* rebase master

* Rebase upstream

* Improve the implementation

* Fix yield col not in group cols

* support aggregation in YIELD

* Address CPWstatic and liuyu85cn's comments
liwenhui-soul pushed a commit to liwenhui-soul/nebula that referenced this pull request May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support limit and group by
9 participants