Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement limit #750

Open
wants to merge 5 commits into
base: master
from

Conversation

@laura-ding
Copy link
Contributor

commented Aug 9, 2019

Closes #676

@laura-ding laura-ding force-pushed the laura-ding:limit branch from 0356a59 to 57ee241 Aug 10, 2019

@jude-zhu jude-zhu requested review from CPWstatic, whitewum and monadbobo and removed request for CPWstatic Aug 11, 2019

src/graph/LimitExecutor.cpp Outdated Show resolved Hide resolved
@whitewum
Copy link
Contributor

left a comment

Generally OK to me.

  1. some test cases should be added.
  2. will you add support for offset? if yes, add an issue to record
src/parser/test/ParserTest.cpp Show resolved Hide resolved
src/parser/test/ParserTest.cpp Show resolved Hide resolved
src/parser/TraverseSentences.h Show resolved Hide resolved
src/graph/LimitExecutor.cpp Show resolved Hide resolved
src/graph/test/GroupByLimitTest.cpp Show resolved Hide resolved
src/graph/test/GroupByLimitTest.cpp Outdated Show resolved Hide resolved
src/graph/test/GroupByLimitTest.cpp Show resolved Hide resolved
src/graph/test/GroupByLimitTest.cpp Show resolved Hide resolved
src/graph/test/GroupByLimitTest.cpp Show resolved Hide resolved
src/graph/test/GroupByLimitTest.cpp Outdated Show resolved Hide resolved

@laura-ding laura-ding force-pushed the laura-ding:limit branch from 57ee241 to 3c629bf Aug 15, 2019

@nebula-community-bot

This comment has been minimized.

Copy link
Member

commented Aug 15, 2019

Unit testing passed.

@jude-zhu jude-zhu requested review from wadeliuyi and whitewum Aug 30, 2019

@laura-ding laura-ding force-pushed the laura-ding:limit branch from 3c629bf to 5ef7cc2 Sep 4, 2019

@nebula-community-bot

This comment has been minimized.

Copy link
Member

commented Sep 4, 2019

Unit testing passed.

@laura-ding laura-ding force-pushed the laura-ding:limit branch from 5ef7cc2 to f3e94d4 Sep 16, 2019

@nebula-community-bot

This comment has been minimized.

Copy link
Member

commented Sep 16, 2019

Unit testing failed.

@nebula-community-bot

This comment has been minimized.

Copy link
Member

commented Sep 16, 2019

Unit testing passed.

@CPWstatic
Copy link
Contributor

left a comment

LGTM. Please resolve the conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.