Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect rate metric in StatsManager #754

Merged
merged 2 commits into from Aug 21, 2019

Conversation

@dutor
Copy link
Member

commented Aug 12, 2019

This bug seems due to improper support to customized clock by folly::MultiLevelTimeSeries

@nebula-community-bot

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

Unit testing passed.

@@ -19,9 +19,9 @@ StatsManager::VT StatsManager::readValue(StatsHolder& stats,
case StatsMethod::COUNT:
return stats.count(level);
case StatsMethod::AVG:
return stats.avg(level);
return stats.template avg<VT>(level);

This comment has been minimized.

Copy link
@dangleptr

dangleptr Aug 14, 2019

Contributor

Why the changes?

This comment has been minimized.

Copy link
@dutor

dutor Aug 14, 2019

Author Member

The default type argument here is double while VT is of type int64_t, thus introducing twice meaningless type conversions.

@laura-ding
Copy link
Contributor

left a comment

Well done

@nebula-community-bot

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

Unit testing passed.

@dutor dutor merged commit 40f5599 into vesoft-inc:master Aug 21, 2019

1 check passed

UnitTest All tests passed.
Details

@dutor dutor deleted the dutor:fix-stats-manager branch Aug 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.