Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fsync upon closing WAL files #820

Merged
merged 3 commits into from Aug 22, 2019

Conversation

@lilydjwg
Copy link
Contributor

commented Aug 21, 2019

Or there will be possible data loss / corruption depending on the exact way how data is interpreted and handled. close doesn't mean automatic fsync.

@nebula-community-bot

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

Can one of the admins verify this patch?

@dutor

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

Thanks for this contribution.

@dutor

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

Jenkins, please run tests.

@nebula-community-bot

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

Unit testing passed.

@dutor
dutor approved these changes Aug 21, 2019
Copy link
Member

left a comment

kim_yes

@dangleptr
Copy link
Contributor

left a comment

Well done

@dangleptr

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2019

Jenkins go

@nebula-community-bot

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

Unit testing failed.

@sherman-the-tank
Copy link
Member

left a comment

Awesome work!

@sherman-the-tank

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

jenkins go

@nebula-community-bot

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

Unit testing passed.

@dangleptr dangleptr merged commit 4e69a97 into vesoft-inc:master Aug 22, 2019

1 check passed

UnitTest All tests passed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.