Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return specialized Vespa connection depending on the ApplicationPackage inheritance #329

Closed
thigm85 opened this issue May 18, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@thigm85
Copy link
Contributor

thigm85 commented May 18, 2022

When deploying a specialized application package such as:

from vespa.gallery import TextSearch 

app_package = TextSearch(id_field="id", text_fields=["title", "body"])

the instance returned by the deployment method could be specific to this specialized application, such as VespaTextSearch, inheriting from the base class Vespa.

Different app use cases have different needs and pyvespa currently lacks a pattern to encode those needs. Just to give another example, this would be useful to natively support TextImageSearch and similar use cases.

@thigm85 thigm85 added the enhancement New feature or request label May 18, 2022
@thigm85 thigm85 self-assigned this May 18, 2022
@thigm85
Copy link
Contributor Author

thigm85 commented Nov 2, 2022

This is no longer in the pyvespa scope.

@thigm85 thigm85 closed this as completed Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant