Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gjoranv/metrics v2 in metricsproxy 2 #12203

Merged
merged 3 commits into from Feb 17, 2020
Merged

Conversation

@gjoranv
Copy link
Contributor

gjoranv commented Feb 14, 2020

No description provided.

gjoranv added 3 commits Feb 13, 2020
- Add new config so that hostname and role can be added to output
- Refactor tests to avoid duplicating code
- Must be added to container, not cluster, due to node specific
  config.
- Extract method to create a metrics handler.
@gjoranv gjoranv requested a review from olaaun Feb 14, 2020
@olaaun
olaaun approved these changes Feb 14, 2020
@gjoranv gjoranv merged commit 48e63dc into master Feb 17, 2020
2 checks passed
2 checks passed
Merge Stop Enforcer Check preventing merges at merge stop.
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gjoranv gjoranv deleted the gjoranv/metrics-v2-in-metricsproxy_2 branch Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.