30s down-moratorium before allowing suspension #14455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmusum
reviewed
Sep 18, 2020
application-model/src/main/java/com/yahoo/vespa/applicationmodel/ClusterId.java
Outdated
Show resolved
Hide resolved
hmusum
requested changes
Sep 18, 2020
…el/ClusterId.java Co-authored-by: Harald Musum <musum@verizonmedia.com>
hmusum
approved these changes
Sep 18, 2020
|
I'm unable to reproduce the Travis failure (ControllerTest, testDevDeployment), and I no longer have the ability to trigger another run on Travis. I'll merge and make a revert just in case. |
hakonhall
deleted the
hakonhall/30s-down-moratorium-before-allowing-suspension
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If all services of a node are down, we used allow suspension. If those services are monitored with /state/v1/health, we have the timestamp the service became unhealthy - the "since" timestamp. Now we will require the services to have been down for at least 30s before allowing suspension based on unhealthiness.
Also, for config servers only, we will log all healthiness transitions to track down some orchestrator issues.