New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Never persist deployment spec for manual environments #8466

Merged
merged 1 commit into from Feb 11, 2019

Conversation

Projects
None yet
3 participants
@mpolden
Copy link
Member

mpolden commented Feb 11, 2019

or @hmusum

@mpolden mpolden requested a review from bratseth Feb 11, 2019

@bratseth
Copy link
Member

bratseth left a comment

Some TODO's really should be done ... looks right to me.

@bratseth bratseth merged commit a88534e into master Feb 11, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Merge Stop Enforcer Check preventing merges at merge stop.
cla/licenses User has a valid Oath CLA
Details

@bratseth bratseth deleted the mpolden/skip-deploymentspecs-for-manual-envs branch Feb 11, 2019

@mpolden

This comment has been minimized.

Copy link
Member Author

mpolden commented Feb 11, 2019

FYI @jonmv

@jonmv

This comment has been minimized.

Copy link
Contributor

jonmv commented Feb 11, 2019

👍
The TODO isn't quite resolved, though. It was more about not manipulating the stored application config during deployment at all, but just when accepting new application packages from the build job.
The comment about dev was something I added to show how horrendous the current code was — guess I should have fixed that there and then 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment