Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using 'name' request parameter, undocumented and not needed #8662

Merged

Conversation

Projects
None yet
2 participants
@hmusum
Copy link
Contributor

hmusum commented Mar 4, 2019

No description provided.

@hmusum hmusum added the DO NOT MERGE label Mar 4, 2019

@hmusum hmusum requested a review from jonmv Mar 4, 2019

@jonmv

jonmv approved these changes Mar 4, 2019

@jonmv

This comment has been minimized.

Copy link
Contributor

jonmv commented Mar 4, 2019

Probably won't break any system tests, because I guess they all prepare with the needed arguments.

@hmusum

This comment has been minimized.

Copy link
Contributor Author

hmusum commented Mar 4, 2019

Agree, I just want to get a release candidate first to be sure. I'll merge when things look better

@hmusum hmusum removed the DO NOT MERGE label Mar 5, 2019

@hmusum hmusum merged commit 0c20251 into master Mar 5, 2019

3 checks passed

Merge Stop Enforcer Check preventing merges at merge stop.
cla/licenses User has a valid Oath CLA
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@hmusum hmusum deleted the hmusum/stop-using-name-parameter-when-creating-session branch Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.