Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deactivate should return NotFoundException #8678

Merged

Conversation

Projects
None yet
2 participants
@hmusum
Copy link
Contributor

hmusum commented Mar 5, 2019

deactivate() will soon throw NotFoundException. Handle that internally in controller and add a test for it.

Deactivate should return NotFoundException
Handle that internally in controller and add a test for it

@hmusum hmusum requested a review from jonmv Mar 5, 2019

@jonmv

jonmv approved these changes Mar 5, 2019

@hmusum hmusum merged commit b6efafb into master Mar 5, 2019

3 checks passed

Merge Stop Enforcer Check preventing merges at merge stop.
cla/licenses User has a valid Oath CLA
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@hmusum hmusum deleted the hmusum/change-deactivate-to-return-not-found-exception branch Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.