Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make LogHandler configurable #8682

Merged
merged 1 commit into from Mar 6, 2019

Conversation

Projects
None yet
3 participants
@freva
Copy link
Contributor

freva commented Mar 5, 2019

No description provided.

@freva freva requested review from olaaun and hmusum Mar 5, 2019

namespace=container.core

## Path to log directory
logDirectory string default="/home/y/logs/vespa/logarchive/"

This comment has been minimized.

Copy link
@freva

freva Mar 5, 2019

Author Contributor

Alternative is to make this a path under VESPA_HOME, then we can avoid /home/y/, but are limited to logs under VESPA_HOME

This comment has been minimized.

Copy link
@hmusum

hmusum Mar 5, 2019

Contributor

Or maybe you could use a relative path for paths under VESPA_HOME as a convention?

You might want to change the name of the config, though, as it is a config for the handler and e.g. for host-admin it will have nothing to do with logserver

This comment has been minimized.

Copy link
@freva

freva Mar 6, 2019

Author Contributor

Fixed, PTAL

@hmusum

hmusum approved these changes Mar 5, 2019

Copy link
Contributor

hmusum left a comment

One comment, otherwise LGTM

@freva freva force-pushed the freva/configurable-loghandler branch from ccbbaa0 to 957e80d Mar 6, 2019

@freva freva force-pushed the freva/configurable-loghandler branch from 957e80d to b601044 Mar 6, 2019

@hmusum

hmusum approved these changes Mar 6, 2019

@olaaun

olaaun approved these changes Mar 6, 2019

@freva freva merged commit 9d0e840 into master Mar 6, 2019

3 checks passed

Merge Stop Enforcer Check preventing merges at merge stop.
cla/licenses User has a valid Oath CLA
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@freva freva deleted the freva/configurable-loghandler branch Mar 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.