Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ContainerCluster abstract. #8727

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@gjoranv
Copy link
Contributor

commented Mar 11, 2019

This should not contain any functional changes, but I'd like to see it through factory before going further.

@gjoranv gjoranv requested review from hmusum and bjorncs Mar 11, 2019

@hmusum

hmusum approved these changes Mar 11, 2019

*
* @author gjoranv
*/
public final class ContainerClusterImpl

This comment has been minimized.

Copy link
@bjorncs

bjorncs Mar 11, 2019

Member

Consider renaming to DefaultContainerCluster if there will be multiple subclasses of ContainerCluster.

@@ -0,0 +1,22 @@
// Copyright 2017 Yahoo Holdings. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.

This comment has been minimized.

Copy link
@bjorncs

bjorncs Mar 11, 2019

Member

Old copyright header

.map(ContainerCluster::toFileReferenceString))
.forEach(builder::bundle);
.map(ContainerCluster::toFileReferenceString))
.forEach(builder::bundle);

This comment has been minimized.

Copy link
@bjorncs

bjorncs Mar 11, 2019

Member

Improves readability a lot 👍

@gjoranv

This comment has been minimized.

Copy link
Contributor Author

commented Mar 13, 2019

Replaced by #8777

@gjoranv gjoranv closed this Mar 13, 2019

@gjoranv gjoranv deleted the gjoranv/container-cluster-types_3 branch Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.