Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Set generation in empty sentinel config response" #8751


None yet
2 participants
Copy link

hmusum commented Mar 12, 2019

Reverts #8746

Returning a newer generation will lead to getting newer generation for every request for this config. If the app is deployed again (with e.g. the original session id + 1 ) the sentinel will refuse to use the config, as it is older than the current generation.

@hmusum hmusum requested a review from arnej27959 Mar 12, 2019

Copy link

arnej27959 left a comment

agreed, we will have to handle this some other way

@arnej27959 arnej27959 merged commit 12edc09 into master Mar 12, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Merge Stop Enforcer Check preventing merges at merge stop.
cla/licenses User has a valid Oath CLA

@arnej27959 arnej27959 deleted the revert-8746-hmusum/increase-config-generation-when-returning-empty-sentinel-config branch Mar 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.