Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allocate 2Gb to tester app, and 75% of the rest to Surefire #8757

Merged
merged 1 commit into from Mar 12, 2019

Conversation

Projects
None yet
2 participants
@jonmv
Copy link
Contributor

commented Mar 12, 2019

@freva please review.

@jonmv

This comment has been minimized.

Copy link
Contributor Author

commented Mar 12, 2019

Or @hmusum

@freva
Copy link
Contributor

left a comment

... what are these magic numbers 😕

@jonmv

This comment has been minimized.

Copy link
Contributor Author

commented Mar 12, 2019

Aren't the comments clear enough? :p

@freva

freva approved these changes Mar 12, 2019

Copy link
Contributor

left a comment

Sure, as long as the flavor doesn't change too much... Might as well have hardcoded those values.

@jonmv jonmv merged commit 073c4be into master Mar 12, 2019

3 checks passed

Merge Stop Enforcer Check preventing merges at merge stop.
cla/licenses User has a valid Oath CLA
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jonmv

This comment has been minimized.

Copy link
Contributor Author

commented Mar 12, 2019

Github, hello.

@jonmv jonmv deleted the jvenstad/redistribute-memory-to-surefire-in-testers branch Mar 12, 2019

@jonmv

This comment has been minimized.

Copy link
Contributor Author

commented Mar 12, 2019

The new thing is that users may ask for larger containers, and this sets aside only the minimum required for the tester app, and lets the user have the rest for tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.