Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send response also when config generation is 0 #8764

Merged
merged 1 commit into from Mar 13, 2019

Conversation

Projects
None yet
2 participants
@hmusum
Copy link
Contributor

commented Mar 12, 2019

Needed for returning empty sentinel config, since we cannot use a new generation
numbed. 0 is used as a special generation number that should allow response
to be given to client even if it is not higher than the current generation.

Send response also when config generation is 0
Needed for returning empty sentinel config, since we cannot use a new generation
numbed. 0 is used as a special generation number that should allow response
to be given to client even if it is not higher than the current generation.

@hmusum hmusum added the DO NOT MERGE label Mar 12, 2019

@hmusum hmusum requested a review from arnej27959 Mar 12, 2019

@hmusum hmusum removed the DO NOT MERGE label Mar 13, 2019

@arnej27959
Copy link
Contributor

left a comment

this looks like a correct fix to me. i'm just a bit confused on why it doesn't use config.hasNewerGeneration - but that currently requires "greater than" while here it was "greater than or equal".

@hmusum

This comment has been minimized.

Copy link
Contributor Author

commented Mar 13, 2019

Thanks, I will look into if we can use config.hasNewerGeneration(), that would be better

@hmusum hmusum merged commit 7aa84a3 into master Mar 13, 2019

3 checks passed

Merge Stop Enforcer Check preventing merges at merge stop.
cla/licenses User has a valid Oath CLA
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@hmusum hmusum deleted the hmusum/send-response-when-config-generation-is-0 branch Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.